Draft: importer: Add ability to verify copy and move operations #5217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid corrupting files and worse, remove the original files (move), a quick check is added to ensure files are still in order.
On failure the crc is printed to aid in discovering if the problem was with the source (unlikely) or destination file. Using
filecmp
would only tell us of a miss-match, but making it harder to figure out why/where things fail.Since
beets import
can be destructive (move), we want to be delicate here.To Do
docs/
to describe it.)docs/changelog.rst
to the bottom of one of the lists near the top of the document.)